tgravescs commented on a change in pull request #25409: [SPARK-28414][WEBUI] UI
updates to show resource info in Standalone
URL: https://github.com/apache/spark/pull/25409#discussion_r317131068
##########
File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
##########
@@ -242,6 +243,22 @@ private[deploy] class Worker(
System.exit(1)
}
}
+ resources.keys.foreach { rName =>
+ resourcesUsed(rName) = MutableResourceInfo(rName, new HashSet[String])
+ }
+ }
+
+ private def updateResourcesUsed(deltaInfo: Map[String, ResourceInformation],
add: Boolean)
Review comment:
I'd say just create 2 functions for this, when looking at how this gets
called its not nearly as clear as just saying addResourcesUsed,
removeResourceUsed, user has to figure out what other parameter is.
also shrinks the code as you simply need 2 lines:
deltaInfo.foreach { case (rName, rInfo) =>
resourcesUsed(rName) += resourcesUsed(rName) + rInfo
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
