HeartSaVioR commented on issue #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#issuecomment-524511058 Sorry it took so long time to revisit review comments. Reflected review comments or left comments. I didn't address some comments for existing code, as this patch is already 2000 lines change so far and we'd be better to focus addressing on code changes in PR. Let's make it backlog for these cases. @gaborgsomogyi @vanzin Could we have another round of reviews? Thanks in advance!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
