choojoyq commented on a change in pull request #25439: [SPARK-28709][DSTREAMS]
- Fix StreamingContext leak through Streaming…
URL: https://github.com/apache/spark/pull/25439#discussion_r317351660
##########
File path: core/src/main/scala/org/apache/spark/ui/WebUI.scala
##########
@@ -93,6 +93,7 @@ private[spark] abstract class WebUI(
attachHandler(renderJsonHandler)
val handlers = pageToHandlers.getOrElseUpdate(page,
ArrayBuffer[ServletContextHandler]())
handlers += renderHandler
+ handlers += renderJsonHandler
Review comment:
I think so, seems that it wasn't an issue in past cause other tabs can't be
detached in runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
