dongjoon-hyun commented on a change in pull request #25458: [SPARK-27931][SQL]
Accept 'on' and 'off' as input and trim input for the boolean data type.
URL: https://github.com/apache/spark/pull/25458#discussion_r317370080
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
##########
@@ -65,12 +65,15 @@ object StringUtils extends Logging {
"(?s)" + out.result() // (?s) enables dotall mode, causing "." to match
new lines
}
- private[this] val trueStrings = Set("t", "true", "y", "yes",
"1").map(UTF8String.fromString)
- private[this] val falseStrings = Set("f", "false", "n", "no",
"0").map(UTF8String.fromString)
+ private[this] val trueStrings =
Review comment:
Could you add a comment before this line? Something like the following.
> "true", "yes", "1", "false", "no", "0", and unique prefixes of these
strings are accepted.
Otherwise, it's hard to recognize why we don't accept "o" here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
