Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/4014#discussion_r23425907
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -649,7 +684,9 @@
https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation%2C+Cube%2C
inputExprs.map(nodeToExpr),
unescapedScript,
output,
- withWhere))
+ withWhere, inputFormat, outputFormat,
--- End diff --
I would like to put the `inputFormat`, `outputFormat` `inputSerDe` etc.
into a single object, named `ScriptInputOutputSchema`, and the `SQLContext` and
`HiveContext` may have different implementatio nof the
`ScriptInputOutputSchema`. that's how the `Analyzer` of·SQLContext` or
`HiveContext` works (to resolve them, e.g. Schema extracting, SerDe class
existence checking etc.).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
