srowen commented on a change in pull request #25423:
[SPARK-28701][test-hadoop3.2][test-java11][k8s] adding java11 support for pull
request builds
URL: https://github.com/apache/spark/pull/25423#discussion_r317655226
##########
File path: dev/run-tests.py
##########
@@ -404,6 +404,12 @@ def run_scala_tests(build_tool, hadoop_version,
test_modules, excluded_tags):
if excluded_tags:
test_profiles += ['-Dtest.exclude.tags=' + ",".join(excluded_tags)]
+ # set up java11 env if this is a pull request build with 'test-java11' in
the title
+ if "test-java11" in os.environ["ghprbPullTitle"].lower():
+ os.environ["JAVA_HOME"] = "/usr/java/jdk-11.0.1"
+ os.environ["PATH"] = "%s/bin:%s" % (os.environ["JAVA_HOME"],
os.environ["PATH"])
+ test_profiles += ['-Djava.version=11']
Review comment:
Hm, and why does
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/spark-master-test-maven-hadoop-3.2-jdk-11/
pass then? it is doing the same thing in the Jenkins config. (OK I think I
answered my own question below)
EDIT: Oh, because it doesn't run Pyspark tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
