brkyvz commented on a change in pull request #25363: [SPARK-28628][SQL]
Implement SupportsNamespaces in V2SessionCatalog
URL: https://github.com/apache/spark/pull/25363#discussion_r317796222
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -202,4 +293,32 @@ private[sql] object V2SessionCatalog {
(identityCols, bucketSpec)
}
+
+ private def toCatalogDatabase(
+ db: String,
+ metadata: util.Map[String, String],
+ defaultLocation: Option[URI] = None): CatalogDatabase = {
+ CatalogDatabase(
+ name = db,
+ description = metadata.getOrDefault("comment", ""),
Review comment:
nit: Can we make `"comment"` and `"location"` static variables and use those
static variables through instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
