gatorsmile commented on a change in pull request #24486: [SPARK-27592][SQL] Set 
the bucketed data source table SerDe correctly
URL: https://github.com/apache/spark/pull/24486#discussion_r317839271
 
 

 ##########
 File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveMetastoreCatalogSuite.scala
 ##########
 @@ -284,4 +284,40 @@ class DataSourceWithHiveMetastoreCatalogSuite
     }
 
   }
+
+  test("SPARK-27592 set the bucketed data source table SerDe correctly") {
+    val provider = "parquet"
+    withTable("t") {
+      spark.sql(
+        s"""
+          |CREATE TABLE t
+          |USING $provider
+          |CLUSTERED BY (c1)
+          |SORTED BY (c1)
+          |INTO 2 BUCKETS
+          |AS SELECT 1 AS c1, 2 AS c2
 
 Review comment:
   Only one row is hard to prove Hive can read it correctly. Could you improve 
the tests? 
   
   In addition, try to create a partitioned and bucked table and see whether 
they are readable by Hive. 
   
   You can create a separate test suite for it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to