srowen commented on issue #25576: [SPARK-28866][ML] Persist item factors RDD when checkpointing in ALS URL: https://github.com/apache/spark/pull/25576#issuecomment-525344901 I see what you mean, yeah. So these aren't directly related to your change, but maybe you know: Why .count() after .checkpoint()? Although these loops call .unpersist(), they never .persist()? The non-implicit case doesn't attempt to .unpersist() either of them, nor .persist(). Wouldn't we want to do that for both users and items in both cases?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
