maropu commented on issue #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#issuecomment-525609519 ok, I'll brush up the code based on the comment 1, 2, and 3. > under the "generated code in the current master" line, the example generated code doesn't look right: it looks like you're quoting the generated code from the final aggregate instead of the partial aggregate, because the inputs look like aggregate buffer slot values to me. You intended to quote the partial aggregate code, right? Ur, yea. You're right. I'll update later. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
