HyukjinKwon commented on a change in pull request #25608:
[WIP][SPARK-28894][SQL][TESTS] Report test results of SQLQueryTestSuite
correctly in Jenkins
URL: https://github.com/apache/spark/pull/25608#discussion_r318524598
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -430,7 +430,11 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
listFilesRecursively(new File(inputFilePath)).flatMap { file =>
val resultFile = file.getAbsolutePath.replace(inputFilePath,
goldenFilePath) + ".out"
val absPath = file.getAbsolutePath
- val testCaseName =
absPath.stripPrefix(inputFilePath).stripPrefix(File.separator)
+ val testFilename =
absPath.stripPrefix(inputFilePath).stripPrefix(File.separator)
+
+ // This is a workaround for SPARK-28894. Seems scalatest produces JUnit
XML report
+ // correctly; however, Jenkins seems misunderstanding the dot in the
test name.
+ val testCaseName = testFilename.stripSuffix(".sql")
Review comment:
Okie, so this dot (`.`) was the problem. Hm, I wonder if we have any better
idea than just cutting the extension out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
