cloud-fan commented on a change in pull request #25610:
[SPARK-28899][SQL][TEST] merge the testing in-memory v2 catalogs from catalyst
and core
URL: https://github.com/apache/spark/pull/25610#discussion_r318590455
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTableCatalog.scala
##########
@@ -63,35 +65,42 @@ class TestTableCatalog extends TableCatalog with
SupportsNamespaces {
schema: StructType,
partitions: Array[Transform],
properties: util.Map[String, String]): Table = {
-
if (tables.containsKey(ident)) {
throw new TableAlreadyExistsException(ident)
}
- if (partitions.nonEmpty) {
Review comment:
the sql/core version supports partitions, so the merged version should
support partitions as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
