advancedxy commented on issue #25306: [SPARK-28573][SQL] Convert InsertIntoTable(HiveTableRelation) to DataSource inserting for partitioned table URL: https://github.com/apache/spark/pull/25306#issuecomment-525827317 > Test build #109863 has finished for PR 25306 at commit 9899ade. > > This patch fails Spark unit tests. This patch merges cleanly. This patch adds no public classes. These test failures are introduced by this change. https://github.com/apache/spark/blob/9899adea2f125c350792d1d7b7ded3a629970766/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala#L146-L151 Once we enables the `InsertIntoTable` with stats, the command executed in `InsertIntoHiveTable` as ` CommandUtils.updateTableStats(sparkSession, table)` will actually update stats, and invalid a lot of assumptions. Do we really want to calculate stats when inserting into tables? @cloud-fan
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
