vanzin commented on a change in pull request #22138: [SPARK-25151][SS] Apply Apache Commons Pool to KafkaDataConsumer URL: https://github.com/apache/spark/pull/22138#discussion_r318756289
########## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/FetchedDataPoolSuite.scala ########## @@ -0,0 +1,342 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.kafka010 + +import java.{util => ju} +import java.util.concurrent.TimeUnit + +import scala.collection.JavaConverters._ +import scala.collection.mutable + +import org.apache.kafka.clients.consumer.ConsumerRecord +import org.apache.kafka.common.TopicPartition +import org.jmock.lib.concurrent.DeterministicScheduler +import org.scalatest.PrivateMethodTester + +import org.apache.spark.SparkConf +import org.apache.spark.sql.kafka010.KafkaDataConsumer.CacheKey +import org.apache.spark.sql.test.SharedSparkSession +import org.apache.spark.util.ManualClock + +class FetchedDataPoolSuite extends SharedSparkSession with PrivateMethodTester { + import FetchedDataPool._ + type Record = ConsumerRecord[Array[Byte], Array[Byte]] + + private val dummyBytes = "dummy".getBytes + + // Helper private method accessors for FetchedDataPool + private type PoolCacheType = mutable.Map[CacheKey, CachedFetchedDataList] + private val _cache = PrivateMethod[PoolCacheType]('cache) + + def getCache(pool: FetchedDataPool): PoolCacheType = { + pool.invokePrivate(_cache()) + } + + test("acquire fresh one") { Review comment: Minor, but a lot of these tests look very similar and could probably be calls to a parameterized function. Seems the things that are changing are i. the number of `CacheKey` instances in the pool and ii. the number of times you use the cached entry for each `CacheKey`. So if you have a `testCacheKey(pool, key)` method, you can just call it with the same pool multiple times and with different keys to test the different behaviors you're currently testing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
