Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4174#discussion_r23494851
--- Diff: core/src/test/scala/org/apache/spark/util/EventLoopSuite.scala ---
@@ -185,4 +185,22 @@ class EventLoopSuite extends FunSuite with Timeouts {
}
assert(false === eventLoop.isActive)
}
+
+ test("EventLoop: stop in eventThread") {
+ val eventLoop = new EventLoop[Int]("test") {
+
+ override def onReceive(event: Int): Unit = {
+ stop()
+ }
+
+ override def onError(e: Throwable): Unit = {
+ }
+
+ }
+ eventLoop.start()
+ eventLoop.post(1)
+ eventually(timeout(5 seconds), interval(200 millis)) {
--- End diff --
can we reduce the check interval to like 5ms? Ideally unit tests should run
in a very short amount of time. Having to wait 200ms is pretty long. Would be
great to change rest of this file also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
