juliuszsompolski commented on a change in pull request #25611:
[SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab
UI
URL: https://github.com/apache/spark/pull/25611#discussion_r319134170
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -262,11 +262,15 @@ private[hive] class SparkExecuteStatementOperation(
// HiveServer will silently swallow them.
case e: Throwable =>
val currentState = getStatus().getState()
- logError(s"Error executing query, currentState $currentState, ", e)
- setState(OperationState.ERROR)
- HiveThriftServer2.listener.onStatementError(
- statementId, e.getMessage, SparkUtils.exceptionString(e))
- throw new HiveSQLException(e.toString)
+ if (currentState == OperationState.CANCELED) {
+ return
Review comment:
A client can call cancel() and close() before the execution thread reaches
here.
Could you do:
```
val currentState = getStatus().getState()
if ((currentState == OperationState.CANCELED)
|| (currentStateg == OperationState.CLOSED)
|| (currentState == OperationState.FINISHED)) {
// This may happen if the execution was cancelled, and then closed
from another thread.
logWarning(s"Ignore exception in terminal state with $statementId:
$e")
return
}
```
This follows
https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java#L247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
