jinxingwang commented on a change in pull request #25614: 
[WIP][SPARK-28887][Kubernetes] Executor pod status fix
URL: https://github.com/apache/spark/pull/25614#discussion_r319213088
 
 

 ##########
 File path: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodStates.scala
 ##########
 @@ -18,20 +18,20 @@ package org.apache.spark.scheduler.cluster.k8s
 
 import io.fabric8.kubernetes.api.model.Pod
 
-sealed trait ExecutorPodState {
+sealed trait ExecutorState {
 
 Review comment:
   To not confuse with the pod state, which is defined by k8s.
   The change here includes executor's pod state also some logic state(such as 
if executor container is down, trade it as the pod is down) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to