rdblue commented on a change in pull request #25104: [SPARK-28341][SQL] create
a public API for V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#discussion_r319236874
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1914,9 +1914,12 @@ object SQLConf {
.createOptional
val V2_SESSION_CATALOG = buildConf("spark.sql.catalog.session")
- .doc("Name of the default v2 catalog, used when a catalog is not
identified in queries")
+ .doc("A catalog implementation which will be used as the session catalog
for Spark " +
+ "queries. The implementation must either extend `CatalogExtension`, or
implement " +
+ "`CatalogPlugin`. When extending `CatalogExtension`, the default
session catalog " +
Review comment:
The class needs to implement `CatalogPlugin` to be loaded. I would rephrase
this to "the implementation may extend `CatalogExtension` to be passed the
default session catalog so that it may delegate calls to the built-in Spark
session catalog".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
