dongjoon-hyun commented on a change in pull request #25625:
[SPARK-28920][INFRA] Set up java version for github workflow
URL: https://github.com/apache/spark/pull/25625#discussion_r319332072
##########
File path: .github/workflows/master.yml
##########
@@ -24,4 +24,4 @@ jobs:
run: |
export MAVEN_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=512m
-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN"
export MAVEN_CLI_OPTS="--no-transfer-progress"
- ./build/mvn $MAVEN_CLI_OPTS -DskipTests package
+ ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Djava.version=${{ matrix.java
}} package
Review comment:
Ur, for GitHub workflow, we aims to do build-test with a single JDK. So,
this is not required, isn't it?
Technically, when we build with JDK8 and test them on JDK11, we use
`-Djava.version=11` during testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
