Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4047#issuecomment-71337678
@EntilZha Thanks for sharing your code! I like that it doesn't really
change the model API, but I'm not quite clear on what will be public/private in
the learning algorithm API since most methods/classes are public right now.
Also, would you mind making a JIRA for adding Gibbs sampling for LDA and
linking your code from there? Then we can discuss the implementation on that
JIRA instead of here. (But if there are API changes needed in this PR, please
do point those out.) Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
