cloud-fan commented on a change in pull request #25620: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/25620#discussion_r319504661
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -48,9 +48,10 @@ import org.apache.spark.util.{CompletionIterator,
TaskCompletionListener, Utils}
* @param shuffleClient [[BlockStoreClient]] for fetching remote blocks
* @param blockManager [[BlockManager]] for reading local blocks
* @param blocksByAddress list of blocks to fetch grouped by the
[[BlockManagerId]].
- * For each block we also require the size (in bytes as
a long field) in
- * order to throttle the memory usage. Note that
zero-sized blocks are
- * already excluded, which happened in
+ * For each block we also require two info: 1. the size
(in bytes as a long
+ * field) in order to throttle the memory usage; 2. the
mapId for this
Review comment:
`mapId` -> `mapIndex`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
