squito commented on a change in pull request #24901: [SPARK-28091[CORE] Extend
Spark metrics system with user-defined metrics using executor plugins
URL: https://github.com/apache/spark/pull/24901#discussion_r319643330
##########
File path: core/src/main/java/org/apache/spark/ExecutorPlugin.java
##########
@@ -47,6 +48,17 @@
*/
default void init() {}
+ /**
+ * Initialize the executor plugins used to extend the Spark/Dropwizard
metrics system.
+ *
+ * <p>Each executor will, during its initialization, invoke this method on
each
+ * plugin provided in the spark.executor.metrics.plugins configuration.</p>
+ *
+ * <p>Plugins should register the data sources using the Dropwizard/codahale
API</p>
+ *
+ */
+ default void init(MetricRegistry sourceMetricsRegistry) {}
Review comment:
sorry I forgot to come back to look at this pr. I agree with marcelo's
comment.
I think its fine to the break the api from 2.4. If we want, you could even
still support old plugins by using reflection.
(or even version the api, but that seems like overkill at this point)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
