srowen commented on a change in pull request #25640: SPARK-28921: Upgrade kubernetes client to 4.4.2 URL: https://github.com/apache/spark/pull/25640#discussion_r319732417
########## File path: dev/deps/spark-deps-hadoop-2.7 ########## @@ -101,6 +101,7 @@ jakarta.ws.rs-api-2.1.5.jar jakarta.xml.bind-api-2.3.2.jar janino-3.0.15.jar javassist-3.22.0-CR2.jar +javax.el-3.0.1-b11.jar Review comment: This is a minor technicality, but we'll need to update a few license files if this becomes part of the transitive dependency, as it'll be distributed with Spark: In `LICENSE-binary`, find: ``` Common Development and Distribution License (CDDL) 1.1 ------------------------------------------------------ ``` Add an entry to the beginning of this section like: ``` javax.el:javax.el-api https://javaee.github.io/uel-ri/ ``` On a second look, I may need to review whether we need additional licenses in `license-binary/` but that's a larger issue I'd have to go back and remember about, to see if CDDL needs this. BTW these changes will be needed for the 2.4 backport, but, I think this will back-port cleanly anyway, so may not need the other PR separately. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
