HyukjinKwon commented on a change in pull request #25633: [SPARK-28759][BUILD]
Upgrade scala-maven-plugin to 4.2.0 and fix build profile on AppVeyor
URL: https://github.com/apache/spark/pull/25633#discussion_r319741468
##########
File path: appveyor.yml
##########
@@ -51,7 +51,9 @@ install:
- cmd: R -e "packageVersion('knitr'); packageVersion('rmarkdown');
packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival')"
build_script:
- - cmd: mvn -DskipTests -Psparkr -Phive package
+ # '-Djna.nosys=true' is required to avoid kernel32.dll load failure.
+ # See SPARK-28759.
+ - cmd: mvn -DskipTests -Psparkr -Phive -Djna.nosys=true package
Review comment:
Oh, do you mean
https://github.com/apache/spark/blob/master/R/WINDOWS.md#building-sparkr-on-windows
? Actually this flag fixed an issue specific to Appveyor. So regular Windows
build won't need this flag.
Actually, I have some more additional and required information to document
there. Building Spark on Windows requires `bash` (by Windows 11 or Cygwin) due
to, at least, here:
https://github.com/apache/spark/blob/eed6de1a6533f259cbd60654d3e537ff7088f296/project/SparkBuild.scala#L516
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
