HyukjinKwon commented on a change in pull request #25646: [SPARK-27336][SQL]
Incorrect DataSet.summary() result
URL: https://github.com/apache/spark/pull/25646#discussion_r319789570
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
##########
@@ -51,7 +51,7 @@ import org.apache.spark.sql.types._
usage = """
_FUNC_(col, percentage [, accuracy]) - Returns the approximate percentile
value of numeric
column `col` at the given percentage. The value of percentage must be
between 0.0
- and 1.0. The `accuracy` parameter (default: 10000) is a positive numeric
literal which
+ and 1.0. The `accuracy` parameter (default: 100000) is a positive
numeric literal which
Review comment:
I am not sure about this. The default is already documented and it's already
able to configure. I wouldn't change this unless there's a strong reason to
change its default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
