cloud-fan commented on a change in pull request #25593: [SPARK-27992][SPARK-28881][PYTHON][2.4] Allow Python to join with connection thread to propagate errors URL: https://github.com/apache/spark/pull/25593#discussion_r319815834
########## File path: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala ########## @@ -957,3 +980,17 @@ private[spark] class PythonParallelizeServer(sc: SparkContext, parallelism: Int) } } +/** + * Create a socket server class and run user function on the socket in a background thread. + * This is the same as calling SocketAuthServer.setupOneConnectionServer except it creates Review comment: IIUC the timeout is for establishing the socket connection. Given we build local socket connection between JVM and Python, 10 seconds is fine. And agree with @squito it's nothing about correctness, if weird thing happens users will get an error instead of wrong result. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
