cloud-fan commented on a change in pull request #25642: [SPARK-28916][SQL]
Split subexpression elimination functions code
URL: https://github.com/apache/spark/pull/25642#discussion_r319936953
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -993,6 +994,15 @@ class CodegenContext {
}
}
+ /**
+ * Returns the code for subexpression elimination after splitting it if
necessary.
+ */
+ def subexprFunctionsCode: String = {
+ // Wholestage codegen does not allow subexpression elimination: in that
case, subexprFunctions
Review comment:
Seems like whole-stage-codegen has the same issue, but unfortunately
`splitExpressionsWithCurrentInputs` is not completed yet.
I think the right description here is: whole-stage-codegen supports
subexpression elimination, but we are not able to split the code for it yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
