dongjoon-hyun commented on a change in pull request #25654:
[SPARK-28912][STREAMING] Fixed MatchError in getCheckpointFiles()
URL: https://github.com/apache/spark/pull/25654#discussion_r320028665
##########
File path: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala
##########
@@ -102,7 +102,7 @@ class Checkpoint(ssc: StreamingContext, val
checkpointTime: Time)
private[streaming]
object Checkpoint extends Logging {
val PREFIX = "checkpoint-"
- val REGEX = (PREFIX + """([\d]+)([\w\.]*)""").r
Review comment:
Could you add a unit test case to
`streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala`?
Please use a test case name, `SPARK-28912 Fixed MatchError in
getCheckpointFiles`. That should be fail without your patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
