kiszk commented on a change in pull request #25655: [SPARK-28906][Build] Fix
incorrect information in bin/spark-submit --version
URL: https://github.com/apache/spark/pull/25655#discussion_r320065272
##########
File path: dev/create-release/release-build.sh
##########
@@ -164,7 +164,6 @@ DEST_DIR_NAME="$SPARK_PACKAGE_VERSION"
git clean -d -f -x
rm .gitignore
-rm -rf .git
Review comment:
@dongjoon-hyun Here is the result. I confirmed that release tarballs do not
have `.git` directory.
```
$ tar xf spark-2.3.4-bin-hadoop2.6.tgz
$ cd spark-2.3.4-bin-hadoop2.6/
$ bin/spark-submit --version
Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
/___/ .__/\_,_/_/ /_/\_\ version 2.3.4
/_/
Using Scala version 2.11.8, OpenJDK 64-Bit Server VM, 1.8.0_212
Branch HEAD
Compiled by user ishizaki on 2019-09-02T19:30:42Z
Revision 8c6f8150f3c6298ff4e1c7e06028f12d7eaf0210
Url https://gitbox.apache.org/repos/asf/spark.git
Type --help for more information.
$ ls -al
total 120
drwxr-xr-x 13 ishizaki ishizaki 4096 Sep 3 04:43 .
drwxrwxr-x 5 ishizaki ishizaki 4096 Sep 3 10:31 ..
-rw-r--r-- 1 ishizaki ishizaki 18045 Sep 3 04:43 LICENSE
-rw-r--r-- 1 ishizaki ishizaki 26366 Sep 3 04:43 NOTICE
drwxr-xr-x 3 ishizaki ishizaki 4096 Sep 3 04:43 R
-rw-r--r-- 1 ishizaki ishizaki 3809 Sep 3 04:43 README.md
-rw-r--r-- 1 ishizaki ishizaki 203 Sep 3 04:43 RELEASE
drwxr-xr-x 2 ishizaki ishizaki 4096 Sep 3 04:43 bin
drwxr-xr-x 2 ishizaki ishizaki 4096 Sep 3 04:43 conf
drwxr-xr-x 5 ishizaki ishizaki 4096 Sep 3 04:43 data
drwxr-xr-x 4 ishizaki ishizaki 4096 Sep 3 04:43 examples
drwxr-xr-x 2 ishizaki ishizaki 16384 Sep 3 04:43 jars
drwxr-xr-x 3 ishizaki ishizaki 4096 Sep 3 04:43 kubernetes
drwxr-xr-x 2 ishizaki ishizaki 4096 Sep 3 04:43 licenses
drwxr-xr-x 6 ishizaki ishizaki 4096 Sep 3 04:43 python
drwxr-xr-x 2 ishizaki ishizaki 4096 Sep 3 04:43 sbin
drwxr-xr-x 2 ishizaki ishizaki 4096 Sep 3 04:43 yarn
$ cd ..
$ tar tvf spark-2.3.4-bin-hadoop2.6.tgz | grep
"spark-2.3.4-bin-hadoop2.6/.git"
$
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
