Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3074#discussion_r23509285
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
 ---
    @@ -225,9 +225,22 @@ private[spark] class CoarseMesosSchedulerBackend(
                 .addResources(createResource("cpus", cpusToUse))
                 .addResources(createResource("mem",
                   MemoryUtils.calculateTotalMemory(sc)))
    -            .build()
    +
    +          sc.conf.getOption("spark.executor.docker.image").map { 
image:String =>
    +            val container = task.getContainerBuilder()
    +            val volumes = sc.conf
    +              .getOption("spark.executor.docker.volumes")
    +              .map(MesosSchedulerBackendUtil.parseVolumesSpec _)
    +            val portmaps = sc.conf
    +              .getOption("spark.executor.docker.portmaps")
    --- End diff --
    
    it seems that these are currently only intended to be used in mesos mode. 
Do you think it makes more sense to put them under the 
`spark.mesos.executor.docker.*` namespace?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to