[GitHub] [spark] zhengruifeng edited a comment on issue #25662: [SPARK-28958][ML][PYSPARK][WIP] pyspark.ml function parity

[GitBox]

zhengruifeng edited a comment on issue #25662: [SPARK-28958][ML][PYSPARK][WIP] 
pyspark.ml function parity
URL: https://github.com/apache/spark/pull/25662#issuecomment-527423383
 
 
   Since I remove the setters generated by `_shared_params_code_gen.py`, it 
seems that all 
algorithms(classification/regression/clustering/als/features/fpm/etc) needed to 
be updated in one batch.
   This PR is now incomplete, and only modify classification&regression for 
now, because in this way I need to change too many place in a single PR. I 
wander if there is a better way to do this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org