juliuszsompolski commented on a change in pull request #25611:
[SPARK-28901][SQL] SparkThriftServer's Cancel SQL Operation show it in JDBC Tab
UI
URL: https://github.com/apache/spark/pull/25611#discussion_r320266627
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
##########
@@ -231,28 +244,33 @@ object HiveThriftServer2 extends Logging {
trimExecutionIfNecessary()
sessionList(sessionId).totalExecution += 1
executionList(id).groupId = groupId
- totalRunning += 1
}
def onStatementParsed(id: String, executionPlan: String): Unit =
synchronized {
executionList(id).executePlan = executionPlan
executionList(id).state = ExecutionState.COMPILED
}
- def onStatementError(id: String, errorMessage: String, errorTrace:
String): Unit = {
- synchronized {
- executionList(id).finishTimestamp = System.currentTimeMillis
- executionList(id).detail = errorMessage
- executionList(id).state = ExecutionState.FAILED
- totalRunning -= 1
- trimExecutionIfNecessary()
- }
+ def onStatementCanceled(id: String): Unit = synchronized {
+ executionList(id).finishTimestamp = System.currentTimeMillis
+ executionList(id).state = ExecutionState.CANCELED
+ trimExecutionIfNecessary()
+ }
+
+
+ def onStatementError(
+ id: String,
+ errorMessage: String,
+ errorTrace: String): Unit = synchronized {
Review comment:
ocd nit: changing `errorMessage` to `errorMsg` would make it fit on one line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
