juliuszsompolski commented on a change in pull request #25612:
[SPARK-3137][Core]Replace the global TorrentBroadcast lock with fine grained
KeyLock
URL: https://github.com/apache/spark/pull/25612#discussion_r320404785
##########
File path:
core/src/main/scala/org/apache/spark/broadcast/BroadcastManager.scala
##########
@@ -56,7 +57,10 @@ private[spark] class BroadcastManager(
private val nextBroadcastId = new AtomicLong(0)
private[broadcast] val cachedValues = {
- new ReferenceMap(AbstractReferenceMap.HARD, AbstractReferenceMap.WEAK)
+ Collections.synchronizedMap(
+ new ReferenceMap(AbstractReferenceMap.HARD, AbstractReferenceMap.WEAK)
+ .asInstanceOf[java.util.Map[Any, Any]]
Review comment:
nit: would it make compiler happy and be nicer if the val was typed (val
cachedValues: JMap[Any, Any]) instead of doing `asInstanceOf`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
