rdblue commented on a change in pull request #25651: [SPARK-28948][SQL] support 
data source v2 in CREATE TABLE USING
URL: https://github.com/apache/spark/pull/25651#discussion_r320517264
 
 

 ##########
 File path: 
external/avro/src/main/scala/org/apache/spark/sql/v2/avro/AvroDataSourceV2.scala
 ##########
 @@ -35,7 +36,10 @@ class AvroDataSourceV2 extends FileDataSourceV2 {
     AvroTable(tableName, sparkSession, options, paths, None, 
fallbackFileFormat)
   }
 
-  override def getTable(options: CaseInsensitiveStringMap, schema: 
StructType): Table = {
+  override def getTable(
+      options: CaseInsensitiveStringMap,
+      schema: StructType,
+      partitions: Array[Transform]): Table = {
 
 Review comment:
   Why is this not identical to the metadata passed to `createTable`? Is there 
a reason not to pass the table properties as well as the read options?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to