jiangxb1987 commented on a change in pull request #25620: [SPARK-25341][Core]
Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/25620#discussion_r320516725
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
##########
@@ -328,6 +313,47 @@ public ManagedBuffer next() {
}
}
+ private class ShuffleManagedBufferIterator implements
Iterator<ManagedBuffer> {
+
+ private int mapIdx = 0;
+ private int reduceIdx = 0;
+
+ private final String appId;
+ private final String execId;
+ private final int shuffleId;
+ private final long[] mapIds;
+ private final int[][] reduceIds;
+
+ ShuffleManagedBufferIterator(FetchShuffleBlocks msg) {
+ appId = msg.appId;
+ execId = msg.execId;
+ shuffleId = msg.shuffleId;
+ mapIds = msg.mapIds;
+ reduceIds = msg.reduceIds;
+ }
+
+ @Override
+ public boolean hasNext() {
+ // mapIds.length must equal to reduceIds.length, and the passed in
FetchShuffleBlocks
+ // must have non-empty mapIds and reduceIds, see the checking logic in
OneForOneBlockFetcher.
+ return mapIdx < mapIds.length && reduceIdx < reduceIds[mapIdx].length;
+ }
+
+ @Override
+ public ManagedBuffer next() {
+ final ManagedBuffer block = blockManager.getBlockData(
+ appId, execId, shuffleId, mapIds[mapIdx],
reduceIds[mapIdx][reduceIdx]);
+ reduceIdx += 1;
+ if (reduceIdx == reduceIds[mapIdx].length) {
Review comment:
nit:
```
if (reduceIdx < reduceIds[mapIdx].length - 1) {
reduceIdx += 1;
} else {
reduceIdx = 0;
mapIdx += 1;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
