wypoon commented on a change in pull request #25659:
[SPARK-28770][CORE][TESTS]Ignore SparkListenerStageExecutorMetrics in
testApplicationReplay test
URL: https://github.com/apache/spark/pull/25659#discussion_r320574368
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala
##########
@@ -218,8 +219,17 @@ class ReplayListenerSuite extends SparkFunSuite with
BeforeAndAfter with LocalSp
// Verify the same events are replayed in the same order
assert(sc.eventLogger.isDefined)
- val originalEvents = sc.eventLogger.get.loggedEvents
- val replayedEvents = eventMonster.loggedEvents
+ implicit val format = DefaultFormats
+ def exceptCase(a: JValue) = ( a \ "Event").extract[String] match {
+ // If we are logging stage executor metrics, there is a bulk call to
logEvent with
+ // SparkListenerStageExecutorMetrics events via a Map.foreach. The
Map.foreach bulk
+ // operation may not log the events with the same order. So here we
should not compare
+ // SparkListenerStageExecutorMetrics here.
Review comment:
This comment is based on my earlier analysis in the JIRA, which is not quite
correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
