xianyinxin commented on a change in pull request #25626: [SPARK-28892][SQL] Add
UPDATE support for DataSource V2
URL: https://github.com/apache/spark/pull/25626#discussion_r320592663
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -245,6 +246,56 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
}.toArray
DeleteFromTableExec(r.table.asDeletable, filters) :: Nil
+ case UpdateTable(maybeRelation, attrs, values, condition) =>
+ val nested =
attrs.asInstanceOf[Seq[Any]].filterNot(_.isInstanceOf[AttributeReference])
+ if (nested.nonEmpty) {
+ throw new AnalysisException(s"Update only support non-nested fields.
Nested: $nested")
+ }
+
+ val (relation, attrsNames, newValues, newCond) = maybeRelation match {
+ case d: DataSourceV2Relation =>
+ (d, attrs.map(_.name), values, condition)
+ case Project(aliasList: Seq[Alias], r: DataSourceV2Relation) =>
Review comment:
I checked mysql, postgresql, hive and impala. All of these do not support
column alias, and most does not support table alias. I believe it is not a
standard syntax and I'd prefer to remove the column alias and only keep the
table alias.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
