cloud-fan commented on a change in pull request #25600: [SPARK-11150][SQL] 
Dynamic Partition Pruning
URL: https://github.com/apache/spark/pull/25600#discussion_r320627067
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
 ##########
 @@ -263,4 +263,24 @@ object HashJoin {
     }
     keyExpr :: Nil
   }
+
+  /**
+   * Extract a given key which was previously packed in a long value using its 
index to
+   * determine the number of bits to shift
+   */
+  def writeKeyExprAt(keys: Seq[Expression], index: Int): Expression = {
 
 Review comment:
   shall we name it `extractKeyExpr`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to