HeartSaVioR commented on a change in pull request #25631: [SPARK-28928][SS]
Take over Kafka delegation token protocol on sources/sinks
URL: https://github.com/apache/spark/pull/25631#discussion_r320646708
##########
File path:
external/kafka-0-10-token-provider/src/test/scala/org/apache/spark/kafka010/KafkaConfigUpdaterSuite.scala
##########
@@ -76,6 +79,25 @@ class KafkaConfigUpdaterSuite extends SparkFunSuite with
KafkaDelegationTokenTes
val params = Map(
CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG -> bootStrapServers
)
+ testWithTokenSetValues(params, updatedParams => {
+ assert(updatedParams.get(CommonClientConfigs.SECURITY_PROTOCOL_CONFIG)
=== SASL_SSL.name)
Review comment:
nit: It would be more stable if you could refer default value of
configuration instead of referring it (`SASL_SSL`) directly, but not a big deal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
