cloud-fan commented on a change in pull request #25626: [SPARK-28892][SQL] Add
UPDATE support for DataSource V2
URL: https://github.com/apache/spark/pull/25626#discussion_r320692778
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2WriteSupportCheck.scala
##########
@@ -56,6 +56,11 @@ object V2WriteSupportCheck extends (LogicalPlan => Unit) {
failAnalysis(s"Delete by condition with subquery is not supported:
$condition")
}
+ case UpdateTable(_, _, _, condition) =>
Review comment:
can we move it to `DataSourceV2Strategy`? This is not a sanity check, this
is just current limitation. We may support subquery in the future and it's
better to put the current limitation near the implementation.
Let's also move the delete check there too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
