ozancicek commented on a change in pull request #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#discussion_r320709444
########## File path: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala ########## @@ -126,7 +127,13 @@ private[feature] trait RFormulaBase extends HasFeaturesCol with HasLabelCol with /** * :: Experimental :: * Implements the transforms required for fitting a dataset against an R model formula. Currently - * we support a limited subset of the R operators, including '~', '.', ':', '+', '-', '*' and '^'. + * we support a limited subset of the R operators, including '~', '.', ':', '+', '-', '*', '^' + * and 'I()'. Arithmetic expressions which use spark functions or registered UDFs are Review comment: Since expr function is used, I think it should be Spark SQL functions so I'm changing it as such. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
