mgaido91 commented on a change in pull request #25642: [SPARK-28916][SQL] Split
subexpression elimination functions code
URL: https://github.com/apache/spark/pull/25642#discussion_r320767129
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -993,6 +994,14 @@ class CodegenContext {
}
}
+ /**
+ * Returns the code for subexpression elimination after splitting it if
necessary.
+ */
+ def subexprFunctionsCode: String = {
+ // Whole-stage codegen's subexpression elimination is handled in another
code path
+ splitExpressions(subexprFunctions, "subexprFunc_split", Seq("InternalRow"
-> INPUT_ROW))
Review comment:
It is not necessary: if it is empty `splitExpressions` would return an empty
string, anyway I can add it if you think it is more clear
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
