srowen commented on a change in pull request #25628:
[SPARK-28897][Core]'coalesce' error when executing dataframe.na.fill
URL: https://github.com/apache/spark/pull/25628#discussion_r320773968
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala
##########
@@ -435,11 +435,10 @@ final class DataFrameNaFunctions private[sql](df:
DataFrame) {
* Returns a [[Column]] expression that replaces null value in `col` with
`replacement`.
*/
private def fillCol[T](col: StructField, replacement: T): Column = {
- val quotedColName = "`" + col.name + "`"
val colValue = col.dataType match {
case DoubleType | FloatType =>
- nanvl(df.col(quotedColName), lit(null)) // nanvl only supports these
types
- case _ => df.col(quotedColName)
+ nanvl(df.col(col.name), lit(null)) // nanvl only supports these types
Review comment:
Won't this break other code? I am not sure you can just remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
