cloud-fan commented on a change in pull request #25410: [SPARK-28690][SQL] Add
`date_part` function for timestamps/dates
URL: https://github.com/apache/spark/pull/25410#discussion_r320776055
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1963,3 +1963,91 @@ case class Epoch(child: Expression, timeZoneId:
Option[String] = None)
defineCodeGen(ctx, ev, c => s"$dtu.getEpoch($c, $zid)")
}
}
+
+object DatePart {
+
+ def parseExtractField(
+ extractField: String,
+ source: Expression,
+ errorHandleFunc: => Unit): Expression =
extractField.toUpperCase(Locale.ROOT) match {
+ case "MILLENNIUM" | "MILLENNIA" | "MIL" | "MILS" => Millennium(source)
+ case "CENTURY" | "CENTURIES" | "C" | "CENT" => Century(source)
+ case "DECADE" | "DECADES" | "DEC" | "DECS" => Decade(source)
+ case "YEAR" | "Y" | "YEARS" | "YR" | "YRS" => Year(source)
+ case "ISOYEAR" => IsoYear(source)
+ case "QUARTER" | "QTR" => Quarter(source)
+ case "MONTH" | "MON" | "MONS" | "MONTHS" => Month(source)
+ case "WEEK" | "W" | "WEEKS" => WeekOfYear(source)
+ case "DAY" | "D" | "DAYS" => DayOfMonth(source)
+ case "DAYOFWEEK" => DayOfWeek(source)
+ case "DOW" => Subtract(DayOfWeek(source), Literal(1))
+ case "ISODOW" => Add(WeekDay(source), Literal(1))
+ case "DOY" => DayOfYear(source)
+ case "HOUR" | "H" | "HOURS" | "HR" | "HRS" => Hour(source)
+ case "MINUTE" | "M" | "MIN" | "MINS" | "MINUTES" => Minute(source)
+ case "SECOND" | "S" | "SEC" | "SECONDS" | "SECS" => Second(source)
+ case "MILLISECONDS" | "MSEC" | "MSECS" | "MILLISECON" | "MSECONDS" | "MS"
=>
+ Milliseconds(source)
+ case "MICROSECONDS" | "USEC" | "USECS" | "USECONDS" | "MICROSECON" | "US"
=>
+ Microseconds(source)
+ case "EPOCH" => Epoch(source)
+ case other =>
+ errorHandleFunc.asInstanceOf[Expression]
Review comment:
we can declare `errorHandleFunc` as `=> Nothing`, then just return
`errorHandleFunc` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
