ozancicek commented on issue #24939: [SPARK-18569][ML][R] Support RFormula arithmetic, I() and spark functions URL: https://github.com/apache/spark/pull/24939#issuecomment-527933279 > this is very good and can be super powerful. sorry about the delay but I'm back on and can help to merge this. > > a few minor comments, please see if you have some time to address them. thanks for this contribution! > > question: > > * does this break model persistence? a saved model from spark 2.3 or 2.4 getting loaded in a newer spark, for example? > * generally, I think skipSpace is a good idea, could you add more tests for this since it changes existing behavior and not just for `I()`? Thanks for the review and updates! I haven't initially thought about persistence compatibility, thanks for the notice. As there is only one additional field to be persisted, I've updated the model loader not to break when loading an old model which doesn't include that additional field. I also added additional tests for skipSpace to RFormulaParserSuite. If there is some additional tests you have in mind, please let me know and I'll add more. All the changes are in the most recent commit.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
