zsxwing commented on a change in pull request #25680: [PARK-28976][CORE]Use
KeyLock to simplify MapOutputTracker.getStatuses
URL: https://github.com/apache/spark/pull/25680#discussion_r320894818
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -707,51 +710,18 @@ private[spark] class MapOutputTrackerWorker(conf:
SparkConf) extends MapOutputTr
if (statuses == null) {
logInfo("Don't have map outputs for shuffle " + shuffleId + ", fetching
them")
val startTimeNs = System.nanoTime()
- var fetchedStatuses: Array[MapStatus] = null
- fetching.synchronized {
- // Someone else is fetching it; wait for them to be done
- while (fetching.contains(shuffleId)) {
- try {
- fetching.wait()
- } catch {
- case e: InterruptedException =>
Review comment:
InterruptedException is swallowed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
