vanzin commented on a change in pull request #24901: [SPARK-28091[CORE] Extend Spark metrics system with user-defined metrics using executor plugins URL: https://github.com/apache/spark/pull/24901#discussion_r320895096
########## File path: core/src/main/java/org/apache/spark/ExecutorPluginContext.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark; + +import com.codahale.metrics.MetricRegistry; +import org.apache.spark.annotation.DeveloperApi; + +/** + * This class encapsulates the input for the ExecutorPlugin interface. It provides a + * layer of indirection to ease future extensions of executor plugins, without breaking the API. + */ +@DeveloperApi +public class ExecutorPluginContext { + + public MetricRegistry executorPluginMetricRegistry; Review comment: Also, on a separate comment: instead of exposing a shared registry, how about a method `registerMetricsSource` that returns a new metrics registry just for the plugin? Then, internally, the implementation of the context could avoid clashes in metric names from different plugins by using the plugin name as the source name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
