rdblue commented on a change in pull request #25104: [SPARK-28341][SQL] create
a public API for V2SessionCatalog
URL: https://github.com/apache/spark/pull/25104#discussion_r320945663
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
##########
@@ -39,20 +39,18 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap
/**
* A [[TableCatalog]] that translates calls to the v1 SessionCatalog.
*/
-class V2SessionCatalog(sessionState: SessionState) extends TableCatalog {
+class V2SessionCatalog(catalog: SessionCatalog, conf: SQLConf) extends
TableCatalog {
+
+ def this(sessionState: SessionState) = this(sessionState.catalog,
sessionState.conf)
Review comment:
I don't think the no-arg constructor is needed after this commit. When this
class was created by the catalog loader, it needed to have a no-arg
constructor. After this commit, this class is only instantiated internally by
Spark. We can remove all of these constructors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
