LucaCanali commented on a change in pull request #24901: [SPARK-28091[CORE]
Extend Spark metrics system with user-defined metrics using executor plugins
URL: https://github.com/apache/spark/pull/24901#discussion_r320975150
##########
File path: core/src/main/java/org/apache/spark/ExecutorPlugin.java
##########
@@ -44,8 +44,19 @@
*
* <p>Plugins should create threads in their implementation of this method
for
* any polling, blocking, or intensive computation.</p>
+ *
+ * <p>The user-supplied init method for this class is initialized passing
+ * executorPluginContext, which contains an handle to the metric registry of
the
+ * executorPlugin. This allows to add custom metrics (gauges, counters,
etc).</p>
+ *
+ * <p>The Spark executor code will wait on the completion of the execution
of the init method.
Review comment:
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
