xianyinxin commented on a change in pull request #25626: [SPARK-28892][SQL] Add
UPDATE support for DataSource V2
URL: https://github.com/apache/spark/pull/25626#discussion_r321061989
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -422,12 +422,30 @@ case class DataSourceStrategy(conf: SQLConf) extends
Strategy with Logging with
}
object DataSourceStrategy {
+
+ /**
+ * Tries to translate a Catalyst [[Expression]] into data source
[[Expression]].
+ *
+ * @return a `Some[catalog.v2.expressions.Expression]` if the input
[[Expression]]
+ * is convertible, otherwise a `None`.
+ */
+ protected[sql] def translateExpression(
Review comment:
Is `Expression` the right place where this util should go? This util
translate the inner `Expression` to the public
`catalog.v2.expressions.Expression` and it belongs to nether of the two. My
first thinking is there's another `translateFilter` in `DataSourceAnalysis`
which translate the inner `Expression` to the public datasource `Filter`, it
has similar function with `translateExpression`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
